-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Use archspec for CPU features #9930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Awesome! Will be useful for enabling things like numpy/numpy#13516, I'm guessing. Even though it'd be another dimension on the build-matrix, there's probably 2-3 variants that'd be worth building for...? |
numpy/numpy#13516 is a different thing which has runtime cpu detection within numpy itself. |
Are you 100% sure? It seems heavily dependent on many things at build time:
The default minimum does not include AVX on x86, for example. But numpy PR aside, IIUC, this should enable to have different compiler builds per (group of) cpu features, right? |
Yes |
@jjhelmus, @mingwandroid, @katietz, any thoughts on this? |
ping on this |
ping on this again |
xref #10057 regarding fixing virtual packages just in case this is relevant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We finally got CI unstuck so hopefully we can review this soon; I'm afraid I don't know enough to comment intelligently, other than to ask if perhaps a test or two is in order?
@isuruf: can you please provide some context for this and (possibly) PR#9461? Having conda provide information about the CPU it's running on seems handy, but I'm curious if you had specific use cases in mind. Also, with this PR, would you want to make conda explicitly dependent on the |
Sure. There are some packages that don't support runtime detection of CPUs and they need to be built for different architectures. With the CPU type available in the solver, we can build different variants of the same package and make sure the correct package is installed.
I'm fine with any option. |
@leofang, it's up to the downstream packages on how to use this. I was thinking of adding a |
cc @manodeep on using this in the corrfunc feedstock |
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
And fix virtual packages when using
CONDA_SUBDIR
commands.See https://github.com/archspec/archspec for the naming scheme.