Minor fixes and deprecations from #12771 #15062

kenodegard · 2025-07-31T20:15:56Z

Description

Extracted smaller fixes from #12771 in order to get them included in 25.7.0 release.

Checklist - did you ...

Add a file to the news directory (using the template) for the next release's release notes?
Add / update necessary tests?
~~Add / update outdated documentation?~~

kenodegard · 2025-07-31T20:20:26Z

conda/env/env.py

@@ -308,4 +308,4 @@ def print_result(args, prefix, result):
                actions["PIP"] = result["pip"]
            common.stdout_json_success(prefix=prefix, actions=actions)
    else:
-        install.print_activate(args.name or prefix)
+        common.print_activate(args.name or prefix)


conda/conda/cli/install.py

Lines 158 to 162 in 08c7e5d

@deprecated("25.9", "26.3", addendum="Use conda.cli.common.print_activate()")

def print_activate(env_name_or_prefix): # pragma: no cover

from .common import print_activate as _print_activate

_print_activate(env_name_or_prefix)

kenodegard · 2025-07-31T20:22:24Z

conda/gateways/logging.py

@@ -208,7 +208,7 @@ def set_all_logger_level(level=DEBUG):
 @cache
 def set_file_logging(logger_name=None, level=DEBUG, path=None):
    if path is None:
-        timestamp = datetime.utcnow().strftime("%Y%m%d-%H%M%S")
+        timestamp = datetime.now(datetime.UTC).strftime("%Y%m%d-%H%M%S")


datetime.utcnow deprecated in 3.12:

Suggested change

timestamp = datetime.now(datetime.UTC).strftime("%Y%m%d-%H%M%S")

timestamp = datetime.now(timezone.utc).strftime("%Y%m%d-%H%M%S")

datetime.UTC was only added in 3.11, but datetime.timezone.utc in Python 3.2. Let's use datetime.timezone.utc

Done in 540fe2a (#15062)

kenodegard · 2025-07-31T20:23:00Z

tests/common/pkg_formats/test_python.py

@@ -12,7 +12,8 @@
 import pytest

 from conda.common.path import get_python_site_packages_short_path
-from conda.common.pkg_formats.python import (
+from conda.common.url import join_url
+from conda.plugins.prefix_data_loaders.pypi.pkg_format import (


conda/conda/common/pkg_formats/python.py

Lines 42 to 46 in 08c7e5d

deprecated.module(

"25.9",

"26.3",

addendum="Use 'conda.plugins.prefix_data_loaders.pypi.pkg_format' hook instead",

)

kenodegard · 2025-07-31T20:23:37Z

tests/test_create.py

@@ -535,7 +536,7 @@ def test_noarch_python_package_with_entry_points(
    entry point script, "pygmentize".
    """
    with tmp_env("pygments") as prefix:
-        py_ver = get_python_version_for_prefix(prefix)
+        py_ver = get_major_minor_version(PrefixData(prefix).get("python", None).version)


conda/conda/core/prefix_data.py

Lines 682 to 695 in 08c7e5d

@deprecated("25.9", "26.3", addendum="Use `PrefixData.get('python').version` instead.")

def get_python_version_for_prefix(prefix: os.PathLike) -> str | None:

"""

For the given conda prefix, return the version of the Python installation

in that prefix.

"""

# returns a string e.g. "2.7", "3.4", "3.5" or None

record = PrefixData(prefix).get("python", None)

if record is not None:

if record.version[3].isdigit():

return record.version[:4]

else:

return record.version[:3]

return None

kenodegard · 2025-07-31T20:26:20Z

tests/test_fetch.py

@@ -114,7 +114,6 @@ def test_resume_download(tmp_path):
    responses.add(
        responses.GET,
        url_pattern,
-        stream=True,


stream boolean argument has been deprecated:

codspeed-hq · 2025-07-31T20:33:10Z

CodSpeed Instrumentation Performance Report

Merging #15062 will not alter performance

_{Comparing kenodegard:minor-fixes (540fe2a) with main (08c7e5d)}

Summary

✅ 21 untouched benchmarks

jezdez · 2025-08-01T08:58:21Z

news/15062-deprecate-disk-create

+* Mark `conda.gateways.disk.create.create_application_entry_point` as pending deprecation, to be removed in 26.9. (#15062)
+* Mark `conda.gateways.disk.create.ProgressFileWrapper` as pending deprecation, to be removed in 26.9. (#15062)
+* Mark `conda.gateways.disk.create.create_fake_executable_softlink` as pending deprecation, to be removed in 26.9. (#15062)
+* Postpone `conda.env.specs.binstar` deprecation to 26.9. (#15062)


jezdez · 2025-08-01T09:01:53Z

conda/gateways/logging.py

@@ -208,7 +208,7 @@ def set_all_logger_level(level=DEBUG):
 @cache
 def set_file_logging(logger_name=None, level=DEBUG, path=None):
    if path is None:
-        timestamp = datetime.utcnow().strftime("%Y%m%d-%H%M%S")
+        timestamp = datetime.now(datetime.UTC).strftime("%Y%m%d-%H%M%S")


Suggested change

timestamp = datetime.now(datetime.UTC).strftime("%Y%m%d-%H%M%S")

timestamp = datetime.now(timezone.utc).strftime("%Y%m%d-%H%M%S")

datetime.UTC was only added in 3.11, but datetime.timezone.utc in Python 3.2. Let's use datetime.timezone.utc

kenodegard added 8 commits July 31, 2025 14:49

Fix print_activate import

5216972

Postpone binstar deprecation

052e981

Use datetime.UTC

0cca583

Fix pkg_formats import

3832fa1

Switch from get_python_version_for_prefix to get_major_minor_version

b9a2e1d

Remove unnecessary keyword

214c086

Deprecate unused functions in conda.gateways.disk.create

bf44139

Add news

c70df71

conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 31, 2025

conda-bot added this to 🔎 Review Jul 31, 2025

github-project-automation bot moved this to 🆕 New in 🔎 Review Jul 31, 2025

kenodegard commented Jul 31, 2025

View reviewed changes

kenodegard moved this from 🆕 New to 🏗️ In Progress in 🔎 Review Jul 31, 2025

kenodegard added this to the 25.7.x milestone Jul 31, 2025

kenodegard marked this pull request as ready for review July 31, 2025 22:00

kenodegard requested a review from a team as a code owner July 31, 2025 22:00

kenodegard moved this from 🏗️ In Progress to 👀 In Review in 🔎 Review Jul 31, 2025

jezdez requested changes Aug 1, 2025

View reviewed changes

github-project-automation bot moved this from 👀 In Review to 🏗️ In Progress in 🔎 Review Aug 1, 2025

Switch to datetime.timezone.utc.

540fe2a

jezdez approved these changes Aug 1, 2025

View reviewed changes

github-project-automation bot moved this from 🏗️ In Progress to ✅ Approved in 🔎 Review Aug 1, 2025

jezdez enabled auto-merge (squash) August 1, 2025 09:08

jezdez merged commit 80779e9 into conda:main Aug 1, 2025
141 of 143 checks passed

github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Aug 1, 2025

kenodegard deleted the minor-fixes branch August 1, 2025 14:26

kenodegard mentioned this pull request Aug 1, 2025

test: treat deprecation warnings as errors #12771

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Minor fixes and deprecations from #12771 #15062

Minor fixes and deprecations from #12771 #15062

Uh oh!

kenodegard commented Jul 31, 2025 •

edited

Loading

Uh oh!

kenodegard Jul 31, 2025

Uh oh!

kenodegard Jul 31, 2025

Uh oh!

jezdez Aug 1, 2025

Uh oh!

jezdez Aug 1, 2025

Uh oh!

kenodegard Jul 31, 2025

Uh oh!

kenodegard Jul 31, 2025

Uh oh!

kenodegard Jul 31, 2025

Uh oh!

codspeed-hq bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

jezdez Aug 1, 2025

Uh oh!

jezdez Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

	@deprecated("25.9", "26.3", addendum="Use conda.cli.common.print_activate()")
	def print_activate(env_name_or_prefix): # pragma: no cover
	from .common import print_activate as _print_activate

	_print_activate(env_name_or_prefix)

	timestamp = datetime.now(datetime.UTC).strftime("%Y%m%d-%H%M%S")
	timestamp = datetime.now(timezone.utc).strftime("%Y%m%d-%H%M%S")

	deprecated.module(
	"25.9",
	"26.3",
	addendum="Use 'conda.plugins.prefix_data_loaders.pypi.pkg_format' hook instead",
	)

	@deprecated("25.9", "26.3", addendum="Use `PrefixData.get('python').version` instead.")
	def get_python_version_for_prefix(prefix: os.PathLike) -> str \| None:
	"""
	For the given conda prefix, return the version of the Python installation
	in that prefix.
	"""
	# returns a string e.g. "2.7", "3.4", "3.5" or None
	record = PrefixData(prefix).get("python", None)
	if record is not None:
	if record.version[3].isdigit():
	return record.version[:4]
	else:
	return record.version[:3]
	return None

Minor fixes and deprecations from #12771 #15062

Minor fixes and deprecations from #12771 #15062

Uh oh!

Conversation

kenodegard commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist - did you ...

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging #15062 will not alter performance

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kenodegard commented Jul 31, 2025 •

edited

Loading

codspeed-hq bot commented Jul 31, 2025 •

edited

Loading