Skip to content

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jul 21, 2025

Description

The json argument in the arg2spec and specs_from_args functions are unused. This PR cleans this up by deprecating this argument.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@soapy1 soapy1 marked this pull request as ready for review July 21, 2025 19:16
@soapy1 soapy1 requested a review from a team as a code owner July 21, 2025 19:16
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Jul 21, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 21, 2025
Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed Instrumentation Performance Report

Merging #15028 will not alter performance

Comparing soapy1:deprecate-arg2spec-json (565350f) with main (942d4eb)

Summary

✅ 21 untouched benchmarks

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗️ In Progress in 🔎 Review Jul 21, 2025
@soapy1 soapy1 force-pushed the deprecate-arg2spec-json branch from 5894192 to ce7f9ed Compare July 22, 2025 20:29
@soapy1 soapy1 requested a review from kenodegard July 22, 2025 20:30
@soapy1
Copy link
Contributor Author

soapy1 commented Jul 22, 2025

pre-commit.ci autofix

@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Approved in 🔎 Review Jul 23, 2025
@kenodegard kenodegard merged commit fe42f66 into conda:main Jul 23, 2025
75 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants