Add default value for version parameter when setting build value in conda_build_form method #15025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 20, 2025 16:28
…ld_form if using build parameter and version is not set
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @mmc1718. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1176), and ping the bot to refresh the PR. |
travishathaway
previously approved these changes
Jul 22, 2025
|
Because you were the original author for this issue, could you please review it too? |
CodSpeed Instrumentation Performance ReportMerging #15025 will not alter performanceComparing Summary
|
jaimergp
reviewed
Jul 23, 2025
jaimergp
reviewed
Jul 23, 2025
jaimergp
reviewed
Jul 23, 2025
|
Just a couple nits here and there, LGTM otherwise! Thanks! |
Remove redundant assert statement, update punctuation in docs and news Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
jezdez
previously approved these changes
Jul 23, 2025
travishathaway
approved these changes
Jul 30, 2025
|
I had to resolve a merge conflict. The branch should merge once the tests are finished running 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #11200
MatchSpec.conda_build_form: Default to using*as the value forversionparameter in the case where the value is not set (Falsey) inMatchSpecbutbuildparameter is setMatchSpec.conda_build_formChecklist - did you ...
newsdirectory (using the template) for the next release's release notes?