-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add plugin type base class for name normalization #15002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Instrumentation Performance ReportMerging #15002 will not alter performanceComparing Summary
|
kenodegard
commented
Jul 10, 2025
soapy1
previously approved these changes
Jul 10, 2025
3 tasks
jezdez
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some clarifying questions
kenodegard
commented
Jul 16, 2025
jezdez
approved these changes
Jul 22, 2025
soapy1
approved these changes
Jul 22, 2025
3 tasks
This was referenced Aug 13, 2025
Normalize header prefix and names to lowercase for consistency
anaconda/conda-anaconda-telemetry#143
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While we initially didn't expect every conda plugin to have a name we have clearly fallen into this pattern so we might as well standardize it.
And while at it might as well include post-init cleanup to lowercase and strip the name.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?