Skip to content

Conversation

travishathaway
Copy link
Contributor

@travishathaway travishathaway commented Nov 18, 2024

Description

Fixes: #14397

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?
  • Add better test coverage to catch the error that was previously missed

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 18, 2024
@travishathaway
Copy link
Contributor Author

Still needs a test to test for the error state that was not be caught.

Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #14398 will not alter performance

Comparing travishathaway:bugfix-14397 (96b19b1) with main (cf3a0fa)

Summary

✅ 21 untouched benchmarks

@travishathaway travishathaway marked this pull request as ready for review November 18, 2024 14:30
@travishathaway travishathaway requested a review from a team as a code owner November 18, 2024 14:30
@travishathaway travishathaway changed the title Fix for issue 14397 Fixes bug for invalid arguments to conda shell.posix (and others) Nov 18, 2024
@travishathaway
Copy link
Contributor Author

Added tests. Ready for review 🚀

@beeankha beeankha merged commit 1fc2836 into conda:main Nov 20, 2024
62 checks passed
@ForgottenProgramme ForgottenProgramme mentioned this pull request Jan 17, 2025
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

conda shell.posix <invalid-arg> raises exception instead of returning an error message
4 participants