Skip to content

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jul 2, 2025

Description

This PR fixes the EnvironmentConfig model so that the aggressive_update_packages fiels is to be a list of strings opposed to a bool field.

In the Context object, it is defined as a list of strings:

_aggressive_update_packages = ParameterLoader(
        SequenceParameter(
            PrimitiveParameter("", element_type=str), DEFAULT_AGGRESSIVE_UPDATE_PACKAGES
        ),
        aliases=("aggressive_update_packages",),
    )

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@soapy1 soapy1 changed the title Aggresive update packages is a list of strings, not a bool Aggressive update packages is a list of strings, not a bool Jul 2, 2025
@soapy1 soapy1 marked this pull request as ready for review July 2, 2025 18:55
@soapy1 soapy1 requested a review from a team as a code owner July 2, 2025 18:55
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Jul 2, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 2, 2025
Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Instrumentation Performance Report

Merging #14982 will not alter performance

Comparing soapy1:fix-aggresive-update-package-config-type (f31f8a1) with main (01f2286)

Summary

✅ 21 untouched benchmarks

@soapy1 soapy1 force-pushed the fix-aggresive-update-package-config-type branch from 672ff97 to f31f8a1 Compare July 2, 2025 19:28
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Approved in 🔎 Review Jul 2, 2025
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird oversight!

@jezdez jezdez merged commit 9bcb095 into conda:main Jul 3, 2025
75 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants