Rename env.env.Environment to env.env.EnvironmentYaml
#14981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jezdez
reviewed
Jul 2, 2025
conda/env/env.py
Outdated
| with open(self.filename, "wb") as fp: | ||
| self.to_yaml(stream=fp) | ||
|
|
||
|
|
||
| @deprecated("26.3", "26.9") |
There was a problem hiding this comment.
Let's add an addendum here, explaining the change
CodSpeed Instrumentation Performance ReportMerging #14981 will not alter performanceComparing Summary
|
7c83dfe to
d940080
Compare
And deprecate env.env.Environment
d940080 to
9e810e1
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
jezdez
approved these changes
Jul 3, 2025
kenodegard
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #14937.
The new
conda.model.environment.Environmentclass has a very similar name to theconda.env.env.Environmentclass. These classes often intermingle, and their similar names makes working with them confusing.conda.model.environment.Environmentrepresents a conda environment.conda.env.env.Environmentrepresents anenvironment.yamlfile.This PR proposes renaming
conda.env.env.Environment->conda.env.env.EnvironmentYaml, by deprecatingconda.env.env.Environmentand introducing a new classconda.env.env.EnvironmentYaml.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?