-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixing problem with --platform
option for conda env create
#14956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #14956 will degrade performances by 46.96%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think writing implicitly to the config file is okay when running conda env create
with --platform
, at least the users should be informed about this change of behavior.
Co-authored-by: Jannis Leidel <jannis@leidel.info>
Description
Closes: #14949
Currently, when users run
conda env create --platform=<platform> ...
this will initially use the correct platform becausecontext.subdir
is being set correctly, but subsequent calls toconda env update
orconda install
will use erroneously use the system's platform.This happens because we are not creating the
.condarc
file in the environment itself which has thesubdir
set correctly in it. To fix this, I simply copied over the code fromconda/cli/install.py
where this was being done correctly toconda/cli/main_env_create.py
.Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?