Handle exceptions coming from environment spec plugins #14916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #14916 will not alter performanceComparing Summary
|
3 tasks
10 tasks
93f33d1 to
35d9cce
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
jezdez
reviewed
Jun 23, 2025
kenodegard
requested changes
Jun 23, 2025
f663afb to
682d100
Compare
kenodegard
previously approved these changes
Jun 23, 2025
682d100 to
4c8ee08
Compare
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
f62fbd7 to
ff0566c
Compare
kenodegard
previously approved these changes
Jun 23, 2025
jaimergp
reviewed
Jun 24, 2025
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
kenodegard
approved these changes
Jun 24, 2025
|
Looks like this test failure is due to a network error. Probably just needs a rerun |
jezdez
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some more error handling into the environemnt_spec plugin detection process. Now,
if a plugin has an unhandled exception in their
can_handlefunction:detect_environment_specifier) will capture + log errors coming from plugins, instead of erroring outget_environment_specifier_by_name) with unhandled exceptions will wrap the error up in a conda exception and provide information about the error to the userSee the attached tests for examples of how this works.
This PR is just handling exceptions during the plugin detection phase, so that would be in the plugin implementation of the
can_handlefunction. This PR does not introduce any error handling for retrieving an environment from the plugin.depends on the changes to the plugin manager introduced in #14877 and #14914
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?