Refactor cli layer: use the plugin system to read input files #14911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Instrumentation Performance ReportMerging #14911 will not alter performanceComparing Summary
|
3 tasks
7 tasks
d92112f to
bef3efd
Compare
jaimergp
reviewed
Jul 7, 2025
b47ebdc to
5560011
Compare
|
pre-commit.ci autofix |
jaimergp
reviewed
Jul 10, 2025
jaimergp
reviewed
Jul 10, 2025
jaimergp
reviewed
Jul 10, 2025
9cc8285 to
978b726
Compare
a334eca to
72cb8f6
Compare
37a8173 to
971526d
Compare
kenodegard
reviewed
Jul 24, 2025
Comment on lines
+339
to
+343
| names = {MatchSpec(pkg).name for pkg in specs} | ||
| for pkg in context.create_default_packages: | ||
| pkg_name = MatchSpec(pkg).name | ||
| if pkg_name not in names: | ||
| specs.append(pkg) |
There was a problem hiding this comment.
Per the type annotation specs may not necessarily be a list
So what if we do this instead (since the ultimate goal is to add missing default packages):
Suggested change
| names = {MatchSpec(pkg).name for pkg in specs} | |
| for pkg in context.create_default_packages: | |
| pkg_name = MatchSpec(pkg).name | |
| if pkg_name not in names: | |
| specs.append(pkg) | |
| # include default packages but override with specs of the same name | |
| specs = { | |
| MatchSpec(pkg).name: pkg | |
| for pkg in (*context.create_default_packages, *specs) | |
| }.values() |
8ac31ec to
2fc85f9
Compare
|
pre-commit.ci autofix |
|
This PR is getting a little bit confusing to manage with the refactor to use the environment model + the reconciling of the
|
02ed39a to
2fc85f9
Compare
…he EnvironmentConfig
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
…t being compatible
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Validate that specifications and conda package filenames are not both specified in install/update/create commands before creating an Environment object. This is consistent with the behaviour of the currently released conda.
for more information, see https://pre-commit.ci
2fc85f9 to
0ca78d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the CLI layer to:
model.environment.EnvironmentobjectEnvironmentThis refactor is a big change to how conda's cli layer. In order to ensure that we are not changing functionality in unexpected ways. I've outlined all the ways conda package installing related commands work, including noting some bugs (this includes
conda install,conda env create,conda remove, etc.).Some important changes in this PR:
conda install/updatecommands can now read environment.yaml files: Previsouly, onlyconda envcommands could read environment.yaml files. This PR introduces using the plugin system to detect the type of the provided--filesource. So, any plugin installed can be used.Things not included in this PR (can be included in follow up PRs):
handle_txnto execute the installing transactionChecklist - did you ...
Add a file to the
newsdirectory (using the template) for the next release's release notes?Add / update necessary tests?
Add / update outdated documentation?
addresses:
conda.cli.installcleanup (technical details) conda-planning#37conda create --fileandconda env create -fbackends conda-planning#15 and Reconcileconda env createandconda createinput file handling conda-planning#64fixes Use new
Environmentdataclass to refactorconda.cli.installsources conda-planning#63