delay environment activation in dev setup #14910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not activate an environment when initializing the shell integration in the dev script. This activation will use the `default_activation_env` environment name which may not exist in the bootstrap install causing the script to fail. The development base environment is explicitly activated in the next block.
kenodegard
requested changes
Jun 5, 2025
Done, although I have not tested the change on a live machine. |
kenodegard
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not activate an environment when initializing the shell integration in the dev script. This activation will use the
default_activation_envenvironment name which may not exist in the bootstrap install causing the script to fail. The development base environment is explicitly activated in the next block.Example behavior without this script with
default_activation_env: workconfigured:With this change:
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?