Replace get_index and get_reduced_index usage
#14905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_index and get_reduced_indexget_index and get_reduced_index usage
CodSpeed Performance ReportMerging #14905 will not alter performanceComparing Summary
|
|
Blocked by #14924 |
aad7a47 to
6fa85a3
Compare
3 tasks
jaimergp
reviewed
Jun 10, 2025
| @@ -1261,7 +1263,7 @@ def _notify_conda_outdated(self, link_precs): | |||
| file=sys.stderr, | |||
| ) | |||
|
|
|||
| def _prepare(self, prepared_specs): | |||
| def _prepare(self, prepared_specs) -> tuple[ReducedIndex, Resolve]: | |||
There was a problem hiding this comment.
Suggested change
| def _prepare(self, prepared_specs) -> tuple[ReducedIndex, Resolve]: | |
| def _prepare(self, prepared_specs: Iterable[MatchSpec]) -> tuple[ReducedIndex, Resolve]: |
I think? Double check though.
jaimergp
reviewed
Jun 10, 2025
| def test_supplement_index_with_system(): | ||
| index = {} | ||
| _supplement_index_with_system(index) | ||
| def test_deprecated_supplement_index_with_system() -> None: |
There was a problem hiding this comment.
Why are we adding return annotations to tests? 🤔 They never return anything, do they?
There was a problem hiding this comment.
At one point mypy wouldn't by default type check functions unless either the args or return was annotated, so I added these None returns to enable the type checking in my IDE for functions without any args, I've just gotten in the habit of consistently adding them 🤷🏼♂️
travishathaway
approved these changes
Jun 23, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jaimergp
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #13880
Stop using deprecated
conda.core.index.get_indexandconda.core.index.get_reduced_index.Extracted from #12771
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?