Skip to content

Add "env consistency" health check to conda doctor / no solver #14799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
May 22, 2025
Merged

Add "env consistency" health check to conda doctor / no solver #14799

merged 36 commits into from
May 22, 2025

Conversation

ForgottenProgramme
Copy link
Contributor

@ForgottenProgramme ForgottenProgramme commented May 2, 2025 •
edited
Loading

Description

This PR adds a new health check to conda doctor called "env consistency check". This detects whether the environment is consistent or not. It does so by checking for missing dependencies.

A previous PR (#14726) was created to achieve the same but by engaging the solver and determining the "final_state".

Resolves #14715
Closes #14726

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@ForgottenProgramme
add skeleton plugin
d661032
@ForgottenProgramme
make comparision
afefeb4
@ForgottenProgramme
add logic to create a fake channel
f90b103
@ForgottenProgramme
add logic to create a fake channel
c67e1fa
@ForgottenProgramme
create a temp directory
81f82eb
@ForgottenProgramme
populate fake channel
aca7921
@ForgottenProgramme
remove
b706b12
@ForgottenProgramme
add sorting func
02d44b8
@ForgottenProgramme
generate more detailed specs for a stricter consistency check
f59d27d
@ForgottenProgramme
changes based on review
7a2a231
@ForgottenProgramme
use setdefault
b057362
@ForgottenProgramme
Merge branch 'main' of github.com:forgottenprogramme/conda into consi…
231ab88 
…stent-env
@ForgottenProgramme
add test, fix missing noarch/repodata.json issue
811cdd1
@ForgottenProgramme
add test for inconsistent env
8ca4729
@ForgottenProgramme
create a new channel to run the solver in
b3a8f8e
@ForgottenProgramme
remove raise
96f9435
@ForgottenProgramme
remove unneccesary var name
990996d
@ForgottenProgramme
put comments before the line
78cb267
@ForgottenProgramme
print why the env is inconsistent, remove the equality check
c93b479
@ForgottenProgramme
fix broken test
1688b4e
@ForgottenProgramme
redirect output if verbose=False
b2409b3
@ForgottenProgramme
use constant defined in base.constants
25c574f
@ForgottenProgramme
use relative imports
78c83ce
@ForgottenProgramme
remove extra env_consistent fixture, use tmp_env for happy path test
fcf7b73
@ForgottenProgramme
compare installed and listed dependencies to check consistency
a097561
@ForgottenProgramme
remove the raise
22232b6
@ForgottenProgramme ForgottenProgramme requested a review from a team as a code owner May 2, 2025 13:05
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review May 2, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 2, 2025
kenodegard
kenodegard reviewed May 7, 2025
View reviewed changes
@jjhelmus
Copy link
Contributor

jjhelmus commented May 7, 2025

A test for a environment with unmet constrains would be a good addition.

jaimergp
jaimergp reviewed May 9, 2025
View reviewed changes
@jjhelmus
Copy link
Contributor

This may need to special case virtual packages as I do not think they exist as entries in PrefixData

@jezdez jezdez self-requested a review May 14, 2025 12:26
@jjhelmus
Copy link
Contributor

ay need to special case virtual packages as I do not think they exist as entries in PrefixData

This is taken care of already. Sorry for the noise.

jjhelmus
jjhelmus previously approved these changes May 22, 2025
View reviewed changes
kenodegard
kenodegard previously approved these changes May 22, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Approved in 🔎 Review May 22, 2025
@kenodegard
Copy link
Contributor

@ForgottenProgramme need to update tests/core/test_index.py::test_fetch_index since we've added a new package to the test-recipes channel

@ForgottenProgramme ForgottenProgramme dismissed stale reviews from kenodegard and jjhelmus via 7043119 May 22, 2025 16:05
jezdez
jezdez approved these changes May 22, 2025
View reviewed changes
@kenodegard kenodegard merged commit 29e201e into conda:main May 22, 2025
75 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review May 22, 2025
@ForgottenProgramme ForgottenProgramme deleted the no-solver branch May 23, 2025 08:02
@ForgottenProgramme ForgottenProgramme restored the no-solver branch May 23, 2025 08:02
@ForgottenProgramme ForgottenProgramme moved this to Done 💪🏾 in (Anaconda) `conda` May 30, 2025
@ForgottenProgramme ForgottenProgramme self-assigned this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezdez jezdez jezdez approved these changes

@kenodegard kenodegard kenodegard approved these changes

@jjhelmus jjhelmus jjhelmus left review comments

@jaimergp jaimergp Awaiting requested review from jaimergp

Assignees

@ForgottenProgramme ForgottenProgramme

Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
(Anaconda) `conda`
Archived in project
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'check if environment is consistent with solver' health check to conda doctor
6 participants
@ForgottenProgramme @jjhelmus @kenodegard @jezdez @jaimergp @conda-bot