Skip to content

Ensure conda run is tested with --dev #14619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Ensure conda run is tested with --dev #14619

merged 1 commit into from
Feb 25, 2025

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Feb 24, 2025

Description

While working on #14607 we discovered that conda run was using the installer's shell scripts for testing and not the source code's shell scripts. We correct this by injecting the --dev argument anytime we are calling conda run.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 24, 2025
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #14619 will not alter performance

Comparing kenodegard:run-dev (2176a6c) with main (79ffe46)

Summary

✅ 21 untouched benchmarks

@kenodegard kenodegard marked this pull request as ready for review February 24, 2025 17:30
@kenodegard kenodegard requested a review from a team as a code owner February 24, 2025 17:31
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Approved in 🔎 Review Feb 25, 2025
@jezdez jezdez merged commit 31a17ba into conda:main Feb 25, 2025
87 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Feb 25, 2025
@kenodegard kenodegard deleted the run-dev branch February 25, 2025 17:31
@kenodegard kenodegard mentioned this pull request Mar 17, 2025
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants