updating canary release version to 25.1.0 #14493
Conversation
CodSpeed Performance ReportMerging #14493 will degrade performances by 47.23%Comparing Summary
Benchmarks breakdown
|
|
@jezdez and @kenodegard, no idea why this is failing 🙈 |
it would appear we've uncovered another bug, interesting how this hasn't come up anywhere else |
73d64b7 to
42282f5
Compare
|
Added a small change to the failing test. We'll see if this works. I wasn't able to reproduce locally. |
|
I have narrowed the failure down and can replicate it on any OS with the following two tests: pytest \
tests/gateways/test_connection.py::test_get_session_with_url_pattern \
tests/gateways/test_jlap.py::test_jlap_fetch_file |
| mock_context: Context = mocker.patch("conda.gateways.connection.session.context") | ||
| mock_context.channel_settings = ( | ||
| {"channel": channel_settings_url, "auth": "dummy_one"}, |
There was a problem hiding this comment.
This form of context mocking is too broad and results in the context object doing some unfortunate caching
| mocker.patch( | ||
| "conda.base.context.Context.channel_settings", | ||
| new_callable=mocker.PropertyMock, | ||
| return_value=[{"channel": channel_settings_url, "auth": "dummy_one"}], | ||
| ) | ||
| get_auth_handler = mocker.patch( | ||
| "conda.plugins.manager.CondaPluginManager.get_auth_handler" |
There was a problem hiding this comment.
This is a targeted mocking for a specific value within the context object. Since it is so targeted we also need to explicitly patch get_auth_handler as well for the test to work as it did before.
896753f to
342b2e5
Compare
Description
Fixes: #14485
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?