Skip to content

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Nov 18, 2024

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Taken directly from win-arm64/conda-launchers-24.7.1-h2722cbf_1.tar.bz2 at conda-canary/conda-launchers, which were built in this CI run for this commit.

Needs to be signed with Anaconda certificates.

Logs for provenance: logs_31030439748.zip

@jaimergp
Copy link
Contributor Author

pre-commit.ci autofix

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #14401 will not alter performance

Comparing jaimergp:add-win-arm64-launcher (3c962fa) with main (475e6ac)

Summary

✅ 21 untouched benchmarks

@jezdez jezdez self-requested a review November 18, 2024 19:35
@jezdez
Copy link
Member

jezdez commented Nov 18, 2024

I first want to review how the binaries were created in detail

@jaimergp
Copy link
Contributor Author

jaimergp commented Dec 9, 2024

Any updates @jezdez? I'd be happy to guide you through the repository and origin of the binaries, or show how to build these locally.

@jakirkham
Copy link
Member

Happy new year! 🥳

Jaime, maybe it would be good to share the steps you used to build these in a PR comment?

That could help multiple people test the process out (plus documenting it publicly would be of great value to our future selves 🙂)

@jaimergp
Copy link
Contributor Author

It's all coming from conda/conda-launchers CI, as described (perhaps too tersely?) in the opening message. This is not using the experimental Zig builds, but the (fat) MSVC builds that Isuru contributed.

@zooba
Copy link

zooba commented Jan 28, 2025

Anything we can do to help unblock this? Or do we just need @jezdez to free up time for review and approval?

@jezdez
Copy link
Member

jezdez commented Jan 28, 2025

@zooba lemme get back to you on this (no eta)

@wolfv
Copy link
Contributor

wolfv commented Jan 28, 2025

@wolfv
Copy link
Contributor

wolfv commented Jan 28, 2025

@zooba do you have infrastructure to sign binaries like this? The conda binaries that we are currently distributing are signed with an Anaconda key. If Microsoft or the Python team at Microsoft could sign these binaries for us, that would be pretty great.

@zooba
Copy link

zooba commented Jan 29, 2025

We do, but we're not allowed to just put a "Microsoft" signature on these. There'd be more chance of using the PSF's certificate, but I'm not sure how to get that kind of use approved - the PSF is pretty protective of the trademark, and putting it on Conda may concern them.

If you want to enable your own signing, Azure Trusted Signing is what we're using for the PSF cert these days. It's cheap ($10/month) and pretty easy to do individual verification (uses personal ID, like a passport) or you may be able to get NumFOCUS to authorise it. The cert is recognised by default on all Windows machines, and there are tasks for GitHub (and pretty sure it supports OIDC now, though I haven't set it up).

@jezdez
Copy link
Member

jezdez commented Jan 30, 2025

We do, but we're not allowed to just put a "Microsoft" signature on these. There'd be more chance of using the PSF's certificate, but I'm not sure how to get that kind of use approved - the PSF is pretty protective of the trademark, and putting it on Conda may concern them.

With my PSF hat on, I will absolutely not support this idea. Mixing these ecosystems legally this way, in the times of CRA and related legislation, is something we shouldn't do. The conda OSS project is a fiscally sponsored project by NumFOCUS, and not a PSF funded effort, so I always expected that we'd get the needed certs from NF. Logistically, I think this is a topic that requires a CEP, to make sure the conda steering council is aware as representatives of the fiscally sponsored project. In other project this would be expedited by a security focused subteam, but alas we don't have one (yet).

If you want to enable your own signing, Azure Trusted Signing is what we're using for the PSF cert these days. It's cheap ($10/month) and pretty easy to do individual verification (uses personal ID, like a passport) or you may be able to get NumFOCUS to authorise it. The cert is recognised by default on all Windows machines, and there are tasks for GitHub (and pretty sure it supports OIDC now, though I haven't set it up).

NumFOCUS is the way to attain the certificate in my opinion, Anaconda staff has experience setting ATS up, and I think I could make the case to help (not me) if needed. Whether Anaconda would accept the binaries for their distributions is a different question, I don't have an answer currently, as I'm not a lawyer. But that's kind of out of scope of this PR IMO.

@zooba
Copy link

zooba commented Jan 30, 2025

With my PSF hat on, I will absolutely not support this idea.

That's what I hoped, I just wasn't sure who'd claim the authority to say it 😄

Whether Anaconda would accept the binaries for their distributions is a different question

No harm in Anaconda re-signing or rebuilding the binaries, but as you say, out of scope here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🛑 Blocked
Development

Successfully merging this pull request may close these issues.

6 participants