Make sure conda does not use polyglot shebangs #12043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review build status
Once it's done, use this command to try it out in a new conda environment:
|
dholth
reviewed
Nov 2, 2022
|
Ready for review but I want to check the canaries that come out of this PR once #12047 is addressed. |
jezdez
approved these changes
Nov 8, 2022
chenghlee
approved these changes
Nov 8, 2022
beeankha
approved these changes
Nov 15, 2022
kenodegard
approved these changes
Nov 15, 2022
|
Are canaries online again? :D |
jezdez
approved these changes
Nov 17, 2022
|
I asked about the canaries because I wanted to review how the entry points were being rendered 😬 |
|
conda-build 3.23.0 is on defaults now, we'll get the canary builds on the main branch shortly |
|
Awesome, the test changes in the recipe should reveal the shebangs properly. So we just need to check the logs. |
This was referenced Jan 9, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minimum work to fix #11885 and close #11893.
More robust solution long-term available at #11995.
Basically we prevent
condafrom using the polyglot shebang approach with two checks:$PREFIX, we are most probably packagingconda. Do nothing and let prefix replacement handle that at install time (replace_long_shebang()right above our function)conda init --installoutside conda-build (there's no reason to, but 🤷), we ensure they end up with a#!/usr/bin/env pythonshebang by calling the function with a new flag.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?