Bring canary builds inline with tests #12040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By relying on the workflow_run trigger, we cannot guarantee that canary builds are built for a given commit, as the clones are instead occurring based on HEAD.
0e77e03 to
924bd69
Compare
jezdez
reviewed
Nov 1, 2022
jezdez
reviewed
Nov 1, 2022
62869be to
c0b28b1
Compare
3 tasks
jezdez
previously approved these changes
Nov 1, 2022
dholth
previously approved these changes
Nov 1, 2022
Co-authored-by: Jannis Leidel <jannis@leidel.info>
jezdez
approved these changes
Nov 1, 2022
beeankha
approved these changes
Nov 1, 2022
This was referenced Nov 2, 2022
jeskowagner
pushed a commit
to jeskowagner/conda
that referenced
this pull request
Nov 9, 2022
* Bring canary builds inline with tests By relying on the workflow_run trigger, we cannot guarantee that canary builds are built for a given commit, as the clones are instead occurring based on HEAD. * Add news * Label canary builds as branch names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By relying on the
workflow_runtrigger, we cannot guarantee that canary builds are built for a given commit. Workflow runs initiated byworkflow_runare instead always based onHEAD. This becomes a problem if we merge several PRs rapidly before tests and canary build from prior merges are complete.These changes are also mirrored in https://github.com/conda/conda-build, see conda/conda-build#4608.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?