-
Notifications
You must be signed in to change notification settings - Fork 1.9k
tests: add local http server #12024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
tests: add local http server #12024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3da531a
to
41dd738
Compare
jezdez
approved these changes
Nov 8, 2022
jeskowagner
pushed a commit
to jeskowagner/conda
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Jannis Leidel <jannis@leidel.info>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
[bot] added once the contributor has signed the CLA
locked
[bot] locked due to inactivity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test against local http server instead of against github. Runs on a random port in a background thread.
Hopefully we can re-use this for other tests?
Reformatted tests/conda_env/test_create.py.
In addition to being a little bit faster, the local server is helpful when we change the test packages used (since the ones referenced on the main branch are still the older versions).
Resolves #11069
Checklist - did you ...
news
directory (using the template) for the next release's release notes?