Remove toolz.itertoolz.concatv
#12020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e4b802 to
1526698
Compare
dholth
previously approved these changes
Oct 27, 2022
| @@ -905,13 +911,13 @@ def _make_link_actions(transaction_context, package_info, target_prefix, request | |||
| # register_private_env_actions = () | |||
|
|
|||
| # the ordering here is significant | |||
There was a problem hiding this comment.
oh yeah? YOU're significant
dae43a7 to
f3e318d
Compare
jezdez
previously approved these changes
Oct 28, 2022
| *grouped_precs.get(PackageType.VIRTUAL_PYTHON_WHEEL, ()), | ||
| *grouped_precs.get(PackageType.VIRTUAL_PYTHON_EGG_MANAGEABLE, ()), | ||
| *grouped_precs.get(PackageType.VIRTUAL_PYTHON_EGG_UNMANAGEABLE, ()), | ||
| # *grouped_precs.get(PackageType.SHADOW_PYTHON_EGG_LINK, ()), |
There was a problem hiding this comment.
I have no idea what PackageType.SHADOW_PYTHON_EGG_LINK refers to, so I'm worried potentially important information will get lost.
|
I'm OK with transforms like this one not including any refactors (that happen to be nearby the transform). LGTM. |
Standard Python's argument unpacking is sufficient since all of these cases do not need to be lazily evaluated via generators.
Co-authored-by: Jannis Leidel <jannis@leidel.info>
fe6d3d9 to
ea020c6
Compare
dholth
approved these changes
Oct 31, 2022
| @@ -327,7 +327,7 @@ def push_record(record): | |||
| # add feature records for the solver | |||
| known_features = set() | |||
| for rec in reduced_index.values(): | |||
| known_features.update(concatv(rec.track_features, rec.features)) | |||
| known_features.update((*rec.track_features, *rec.features)) | |||
There was a problem hiding this comment.
Good remembering it winds up with (( and )) on either side
jeskowagner
pushed a commit
to jeskowagner/conda
that referenced
this pull request
Nov 9, 2022
* Stop using toolz.concatv Standard Python's argument unpacking is sufficient since all of these cases do not need to be lazily evaluated via generators. * Include vendor licenses and remove legacy vendoring Co-authored-by: Jannis Leidel <jannis@leidel.info>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opting to use argument unpacking instead of
toolz.itertoolz.concatv. All of the uses ofconcatvwere immediately expanded into static types, so the generatorconcatvreturned was unnecessary.Alternative to #11769
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?