Skip to content

Remove toolz.functoolz.excepts usage #12016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2022
Merged

Remove toolz.functoolz.excepts usage #12016

merged 2 commits into from
Oct 26, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Oct 25, 2022 •
edited
Loading

Description

While looking to fix incorrect conda._vendored.toolz import I found that the usage of toolz.functoolz.excepts to be overkill and opted to remove the usage.

Resolves #12015

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added the in-progress issue is actively being worked on label Oct 25, 2022
@kenodegard kenodegard requested a review from a team as a code owner October 25, 2022 21:02
@kenodegard kenodegard self-assigned this Oct 25, 2022
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 25, 2022
dholth
dholth previously approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

jezdez
jezdez approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jezdez jezdez enabled auto-merge (squash) October 26, 2022 11:39
@jezdez jezdez merged commit 2168064 into conda:main Oct 26, 2022
@kenodegard kenodegard mentioned this pull request Oct 26, 2022
Closed
1 task
@kenodegard kenodegard deleted the remove-excepts branch October 26, 2022 13:54
jeskowagner pushed a commit to jeskowagner/conda that referenced this pull request Nov 9, 2022
@kenodegard @jeskowagner
Remove toolz.functoolz.excepts usage (conda#12016)
e19afd4 
* Remove toolz.functoolz.excepts usage

* Add news
@maresb maresb mentioned this pull request May 18, 2023
Closed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

@dholth dholth dholth left review comments

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA in-progress issue is actively being worked on locked [bot] locked due to inactivity
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toolz.functoolz is not vendored
4 participants
@kenodegard @jezdez @dholth @conda-bot