Skip to content

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jun 8, 2023

Description

We should treat deprecation warnings as errors for greater awareness and visibility.

Resolves #12372
Depends on #13884
Depends on #13885
Depends on #13886
Depends on #14901
Depends on #14905
Depends on #14924
Depends on #15062

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Notes from Matt (beckermr):

  • conda appears to be using deprecated modules in its internal set of plugin hooks. My guess is that the intent here was to move the plugins to separate code bases, but this never happened. For now, I have put in context managers that suppress warnings from these internal calls. This way external users will get a warning still, but conda itself won't generate warnings for its own usage.

@kenodegard kenodegard self-assigned this Jun 8, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 8, 2023
@kenodegard kenodegard force-pushed the error-deprecations branch from 5601310 to 09a4c5b Compare June 8, 2023 04:05
Copy link

codspeed-hq bot commented Jan 11, 2024

CodSpeed Performance Report

Merging #12771 will not alter performance

Comparing kenodegard:error-deprecations (3532f07) with main (e341a1f)

Summary

✅ 21 untouched benchmarks

@mbargull
Copy link
Member

Thanks for doing this!
I think having the ::conda scope is a good and reasonable thing to get this going!

In the future we may want to address the external warnings one by one and ultimately drop ::conda and filter out known specific warnings that we can't address ourselves. (We may want to define such filters in code with additional constraints such as dependencies' upper bounds and/or some date -- that way we are forced to revisit the filters from time to time and avoid code rot.)

@jaimergp
Copy link
Contributor

jaimergp commented May 2, 2024

What's the status here? Is there anything I can do to help? 🙏

@kenodegard kenodegard added this to the 24.5.x milestone May 2, 2024
@kenodegard kenodegard changed the base branch from main to 24.5.x May 2, 2024 16:50
@kenodegard kenodegard force-pushed the error-deprecations branch 2 times, most recently from 02945f9 to 8370eca Compare May 2, 2024 18:13
@kenodegard kenodegard force-pushed the error-deprecations branch from 8370eca to a3314e5 Compare May 2, 2024 19:15
@kenodegard
Copy link
Contributor Author

@jaimergp I had completely forgotten about this PR (again), I've split off the easier changes into new PRs with the hopes of including it in the upcoming 24.5.0 release

@kenodegard kenodegard modified the milestones: 24.5.x, 24.7.x May 6, 2024
@kenodegard kenodegard modified the milestones: 24.7.x, 24.9.X Jul 15, 2024
@kenodegard kenodegard changed the base branch from 24.5.x to main August 8, 2024 20:44
@kenodegard kenodegard force-pushed the error-deprecations branch 4 times, most recently from 297058c to 99c7725 Compare August 8, 2024 21:20
@kenodegard kenodegard mentioned this pull request Jun 26, 2025
3 tasks
@kenodegard kenodegard force-pushed the error-deprecations branch from 4b0a9e7 to 7a5df70 Compare June 26, 2025 18:59
@kenodegard kenodegard force-pushed the error-deprecations branch from 7a5df70 to 7c0b565 Compare June 26, 2025 19:01
jezdez added a commit that referenced this pull request Aug 1, 2025
* Fix `print_activate` import

* Postpone binstar deprecation

* Use datetime.UTC

* Fix pkg_formats import

* Switch from get_python_version_for_prefix to get_major_minor_version

* Remove unnecessary keyword

* Deprecate unused functions in conda.gateways.disk.create

* Add news

* Switch to `datetime.timezone.utc`.

---------

Co-authored-by: Jannis Leidel <jannis@leidel.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏗️ In Progress
Development

Successfully merging this pull request may close these issues.

Add pytest settings to handle testing warnings explicitly
7 participants