-
Notifications
You must be signed in to change notification settings - Fork 1.9k
test: treat deprecation warnings as errors #12771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5601310
to
09a4c5b
Compare
09a4c5b
to
b0072ae
Compare
CodSpeed Performance ReportMerging #12771 will not alter performanceComparing Summary
|
c5ff29e
to
b85a1a2
Compare
Thanks for doing this! In the future we may want to address the external warnings one by one and ultimately drop |
What's the status here? Is there anything I can do to help? 🙏 |
02945f9
to
8370eca
Compare
8370eca
to
a3314e5
Compare
@jaimergp I had completely forgotten about this PR (again), I've split off the easier changes into new PRs with the hopes of including it in the upcoming 24.5.0 release |
297058c
to
99c7725
Compare
4b0a9e7
to
7a5df70
Compare
7a5df70
to
7c0b565
Compare
* Fix `print_activate` import * Postpone binstar deprecation * Use datetime.UTC * Fix pkg_formats import * Switch from get_python_version_for_prefix to get_major_minor_version * Remove unnecessary keyword * Deprecate unused functions in conda.gateways.disk.create * Add news * Switch to `datetime.timezone.utc`. --------- Co-authored-by: Jannis Leidel <jannis@leidel.info>
Description
We should treat deprecation warnings as errors for greater awareness and visibility.
Resolves #12372
Depends on #13884
Depends on #13885
Depends on #13886
Depends on #14901
Depends on #14905
Depends on #14924
Depends on #15062
Checklist - did you ...
Add a file to thenews
directory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?Notes from Matt (beckermr):
conda
appears to be using deprecated modules in its internal set of plugin hooks. My guess is that the intent here was to move the plugins to separate code bases, but this never happened. For now, I have put in context managers that suppress warnings from these internal calls. This way external users will get a warning still, but conda itself won't generate warnings for its own usage.