Skip to content

Replace conda.auxlib.collection.frozendict with vendored frozendict #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2022
Merged

Replace conda.auxlib.collection.frozendict with vendored frozendict #11398

merged 3 commits into from
Apr 28, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Apr 5, 2022 •
edited
Loading

Description

Removes custom conda.auxlib.collection.frozendict in favor of the already vendored frozendict.

Resolves #11337

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 5, 2022
@kenodegard kenodegard marked this pull request as ready for review April 5, 2022 19:04
@kenodegard kenodegard requested a review from a team as a code owner April 5, 2022 19:04
@kenodegard kenodegard self-assigned this Apr 5, 2022
@kenodegard kenodegard changed the title Remove conda.auxlib.collection.frozendict Replace conda.auxlib.collection.frozendict with vendored frozendict Apr 5, 2022
beeankha
beeankha reviewed Apr 5, 2022
View reviewed changes
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

beeankha
beeankha approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, selected "comment" vs "approve" earlier

jezdez
jezdez reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a tricky ordering risk I think but in quick research I couldn't find out if collections.abc.Mapping is ordered like dict on Python 3.x or not.

jezdez
jezdez reviewed Apr 7, 2022
View reviewed changes
@jezdez jezdez merged commit cb1b5f3 into conda:master Apr 28, 2022
@kenodegard kenodegard deleted the remove-auxlib-frozendict branch July 28, 2022 18:12
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez left review comments

@beeankha beeankha beeankha approved these changes

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace conda.auxlib.collection.frozendict with vendored frozendict
4 participants
@kenodegard @jezdez @beeankha @anaconda-issue-bot