Skip to content

Combine main_clean's rm_tarballs with rm_pkgs #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2022
Merged

Combine main_clean's rm_tarballs with rm_pkgs #11391

merged 2 commits into from
Apr 18, 2022

Conversation

kenodegard
Copy link
Contributor

The culmination of all recent conda clean work:

Removes/combines rm_tarballs in favor of rm_pkgs. In addition to abstracting/reusing code this change also makes conda clean a little more user friendly by not dumping tons of extra info to the screen:

Normal run

$ conda clean --all --dry-run
Will remove 93 (222.3 MB) tarball(s).
Will remove 1 index cache(s).
Will remove 77 (1.25 GB) package(s).
There are no tempfile(s) to remove.

DryRunExit: Dry run. Exiting.

Verbose run

$ conda clean --all --dry-run -v
Will remove the following tarball(s):
  ~/anaconda/devenv/Darwin/envs/devenv-3.8-c/pkgs
  -------------------------------------------------------------
  - ruamel_yaml-0.15.100-py36h9ed2024_0.conda     244 KB
  - openssl-1.1.1n-hca72f7f_0.conda              2.2 MB
  - certifi-2021.10.8-py39hecd8cb5_2.conda       152 KB
  ...

-----------------
Total:   222.3 MB

Will remove the following index cache(s):
  - ~/anaconda/devenv/Darwin/envs/devenv-3.8-c/pkgs/cache

Will remove the following package(s):
  ~/anaconda/devenv/Darwin/envs/devenv-3.8-c/pkgs
  -------------------------------------------------------------
  - libcurl-7.80.0-h6dfd666_0                    893 KB
  - opt_einsum-3.3.0-pyhd3eb1b0_1                248 KB
  - icu-58.2-h0a44026_3                         67.5 MB
  ...

-----------------
Total:    1.25 GB

There are no tempfile(s) to remove.

DryRunExit: Dry run. Exiting.

@kenodegard kenodegard added this to the 4.13.0 milestone Apr 4, 2022
@kenodegard kenodegard requested a review from a team as a code owner April 4, 2022 18:45
@kenodegard kenodegard self-assigned this Apr 4, 2022
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 4, 2022
@kenodegard kenodegard force-pushed the main_clean-combine branch from c0e4461 to a65f830 Compare April 4, 2022 18:59
travishathaway
travishathaway approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggested change. It's optional though.

@kenodegard kenodegard force-pushed the main_clean-combine branch from 2dd3ab8 to 7503a70 Compare April 5, 2022 16:25
jezdez
jezdez approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@kenodegard kenodegard merged commit 55cd442 into conda:master Apr 18, 2022
@kenodegard kenodegard deleted the main_clean-combine branch April 18, 2022 17:09
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

@travishathaway travishathaway travishathaway approved these changes

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kenodegard @jezdez @travishathaway @anaconda-issue-bot