Fix inconsistencies with conda clean --dryrun
#11385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119b3c2 to
d1d4565
Compare
jezdez
reviewed
Apr 1, 2022
jezdez
approved these changes
Apr 1, 2022
travishathaway
pushed a commit
to travishathaway/conda
that referenced
this pull request
Apr 5, 2022
* Custom action for `-c [PATH [...]]` parsing * Proper dry-run cascading * Split all clean function into `find_*` vs `rm_*` * Remove unnecessary/confusing cache location print * Include tempfiles in json_result * conda clean need --yes for non-interactive * Remove extra black formatting * Remove argparse._copy_items import * Fix typing inconsistencies * Remove deprecated --source-cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 6 kinds of
conda clean:--tarballs--packages--index-cache--tempfiles--all: all of the above--force-pkgs-dirs: nuclear option removing the entire package cachePreviously if running as dry-run only the tarball and package removal checks for the dry-run condition. So running the following had no impact with
--dry-run:--index-cache--tempfiles--force-pkgs_dirs: this is of particular concern given the potentially corrupting nature of this removalFurther if running
--allwith--dry-runthe way the dry-run check is implemented the program exists after only processing the tarballs. So effectively an incomplete dry-run report.This addresses all of these inconsistencies.
Also removes
--source-cacheargument deprecated 5 years ago in conda 4.6.0.