Skip to content

Add python constraint back for --update-deps --only-deps #11378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add python constraint back for --update-deps --only-deps #11378

merged 1 commit into from
Mar 29, 2022

Conversation

kenodegard
Copy link
Contributor

Due to recent updates to the available packages there seems to be a preference for Python 3.9 over Python 3.10 causing Python to be downgraded for the --update-deps --only-deps test:

# installs flask=2.0.1 & python=3.10.3
$ conda create -n deps flask=2.0.1

# is not supposed to update flask/python but it's downgrading python to 3.9.11
$ conda install -n deps flask python --update-deps --only-deps

This is yet another "short-term" fix for the larger issue of our testsuite depending on the everchanging defaults channel.

@kenodegard kenodegard requested a review from a team as a code owner March 28, 2022 22:56
@kenodegard kenodegard self-assigned this Mar 28, 2022
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 28, 2022
@kenodegard kenodegard requested review from chenghlee and jezdez March 28, 2022 22:57
@jezdez jezdez requested a review from jaimergp March 29, 2022 11:41
@jezdez
Copy link
Member

jezdez commented Mar 29, 2022

So IIRC we had trouble with this on the libmamba solver side (where we run these tests as well). @jaimergp do you think we can add this pin back again?

@jaimergp
Copy link
Contributor

I think this will break when Python 3.11 is out. The behavior being tested here is that the Python version shouldn't change across runs unless explicitly asked (e.g. python=3.10). The fix suggested here only patches this temporary hiccup because for whatever reason the solver is finding 3.9 more suitable now 🤷 This shouldn't be happening and in my opinion it's a bug, but who knows what the explanation is...

That said, we are overriding this test downstream. So it does not matter for us.

@jezdez
Copy link
Member

jezdez commented Mar 29, 2022

Thanks @jaimergp, yeah, we'll need to figure out a proper fix. #11170 tracks the Python 3.11 support.

@jezdez jezdez merged commit eed68d0 into conda:master Mar 29, 2022
@kenodegard kenodegard deleted the update-only-deps branch March 30, 2022 00:17
@jezdez jezdez added this to the 4.13.0 milestone Apr 4, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

@chenghlee chenghlee Awaiting requested review from chenghlee

@jaimergp jaimergp Awaiting requested review from jaimergp

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kenodegard @jezdez @jaimergp @anaconda-issue-bot