Issue 11334 replace vendored urllib3 #11373
Conversation
Switching partially to built in urllib.parse.urlparse
|
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @travishathaway. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
|
@anaconda-issue-bot check |
fecf3f0 to
6f47f14
Compare
There was a problem hiding this comment.
I realized that namedtuple already provides as_dict & replace functionality so we should probably not reimplement those but other than that this looks good to me!
edit: also if you rebase to include #11378 the tests should pass again
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
|
@travishathaway oh and let's also include the news about dropping |
Co-authored-by: Jannis Leidel <jannis@leidel.info>
Co-authored-by: Jannis Leidel <jannis@leidel.info>
See #11334 for a full description of this issue.
The goal of this PR was removing our dependency on
urllib3in our_vendorsmodule. I was able to do this by instead relying on theurllib.parse.urlparse. On top of this, I copied over theUrlobject fromurllib3and made some slight modifications to it to make updating the code easier.The
conda.common.urlmodule augments the default parse behavior of the std liburllib.parsemodule. We do this by defining our ownurlparsemethod. Where this method differs from the std. lib. version is that it returns its ownUrlobject instead of aParsedResult. ThisUrlobject is much friendlier to those wishing to reconstitute a URL from various parts (like when stripping out username and password).Acceptance Criteria: