Skip to content

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 24, 2022

Depends on #11351 & #11356

Discovered while writing tests for the untested functionality that:

  • The .trash directory and .trash suffix no longer appear to be in use and we need to investigate removing it altogether
  • Only the --tempfiles function requires a prefix but it doesn't check to ensure a prefix is passed but rather simply accepts any valid path, this is inconsistent and should be revisited

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 24, 2022
@kenodegard kenodegard self-assigned this Mar 24, 2022
@kenodegard kenodegard force-pushed the tests-main_clean branch 2 times, most recently from b6fa6db to ae15941 Compare March 24, 2022 16:34
@kenodegard kenodegard marked this pull request as ready for review March 24, 2022 16:35
@kenodegard kenodegard requested a review from a team as a code owner March 24, 2022 16:35
@kenodegard kenodegard changed the title Reorg and new tests for main_clean Reorg tests for main_clean Mar 24, 2022
@kenodegard kenodegard closed this Mar 24, 2022
@kenodegard kenodegard reopened this Mar 24, 2022
@kenodegard kenodegard closed this Mar 24, 2022
@kenodegard kenodegard reopened this Mar 24, 2022
@kenodegard
Copy link
Contributor Author

@anaconda-issue-bot check

Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenodegard kenodegard changed the title Reorg tests for main_clean Reorg + new tests for main_clean Mar 25, 2022
@kenodegard kenodegard requested review from a team and beeankha March 28, 2022 14:19
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor variable nitpicking, and more oppurtunity to factor out _any_pkg function.

@kenodegard kenodegard requested a review from jezdez March 30, 2022 21:29
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick updates!

@kenodegard kenodegard merged commit bb9b3c0 into conda:master Mar 31, 2022
@kenodegard kenodegard deleted the tests-main_clean branch March 31, 2022 15:58
@jezdez jezdez added this to the 4.13.0 milestone Apr 4, 2022
travishathaway pushed a commit to travishathaway/conda that referenced this pull request Apr 5, 2022
* Move main_clean tests into separate test

* Add test for every clean function

* Add CONDA_TEMP_EXTENSIONS
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants