-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Reorg + new tests for main_clean #11360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b6fa6db
to
ae15941
Compare
@anaconda-issue-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
3d8c0c9
to
33de18a
Compare
dcbafbe
to
3595188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor variable nitpicking, and more oppurtunity to factor out _any_pkg
function.
d58ca19
to
3ce758a
Compare
546d6b1
to
e4ffac2
Compare
e4ffac2
to
82401dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick updates!
* Move main_clean tests into separate test * Add test for every clean function * Add CONDA_TEMP_EXTENSIONS
Depends on
#11351& #11356Discovered while writing tests for the untested functionality that:
.trash
directory and.trash
suffix no longer appear to be in use and we need to investigate removing it altogether--tempfiles
function requires a prefix but it doesn't check to ensure a prefix is passed but rather simply accepts any valid path, this is inconsistent and should be revisited