Skip to content

Remove expensive conda-build autouse fixture #11356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 24, 2022
Merged

Remove expensive conda-build autouse fixture #11356

merged 6 commits into from
Mar 24, 2022

Conversation

kenodegard
Copy link
Contributor

The packages built by this autouse fixture are only used in two places. Blindly building these packages for any test run is unnecessarily expensive (e.g. when trying to run individual tests locally).

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 23, 2022
@kenodegard kenodegard force-pushed the pytest-autouse-fixture branch from 33fc7e9 to 466857e Compare March 23, 2022 18:37
@kenodegard kenodegard force-pushed the pytest-autouse-fixture branch from 2e8f1b1 to 145d33b Compare March 24, 2022 00:23
@kenodegard kenodegard marked this pull request as ready for review March 24, 2022 01:16
@kenodegard kenodegard requested a review from a team as a code owner March 24, 2022 01:16
@kenodegard kenodegard mentioned this pull request Mar 24, 2022
Merged
@kenodegard kenodegard self-assigned this Mar 24, 2022
jezdez
jezdez approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well dang, that's a good idea!

@jezdez jezdez merged commit cab0d9d into conda:master Mar 24, 2022
@jezdez jezdez added this to the 4.13.0 milestone Apr 4, 2022
@kenodegard kenodegard deleted the pytest-autouse-fixture branch July 28, 2022 18:12
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kenodegard @jezdez @anaconda-issue-bot