Skip to content

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 21, 2022

Removing the following unused (or low usage) submodules of conda.auxlib:

  • configuration: conda implements its own way of parsing and handling config files
  • crypt: it's unused why keep it?
  • deprecation: currently unused and probably better to use other tools like python-deprecated
  • factory: unused and documented as being incomplete, so why keep it?
  • path: mostly unused, convenience functions not widely used

Resolves #11338

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 21, 2022
@kenodegard kenodegard force-pushed the remove-unused-auxlib branch 3 times, most recently from e301928 to 4876659 Compare March 21, 2022 20:15
@kenodegard
Copy link
Contributor Author

@travishathaway This is what I'd compiled as safe to remove last week, I had not finished reviewing the remaining submodules of auxlib. Feel free to pick up where I left off or feel free to reassign this back to me if you don't think you'll have time to take a look.

@travishathaway
Copy link
Contributor

@kenodegard I checked out the rest of the sub-modules and it looks like they are all currently in use else in the repository. I don't believe anything else needs to be removed.

@kenodegard kenodegard force-pushed the remove-unused-auxlib branch from 4876659 to f7b7ac5 Compare March 28, 2022 14:58
@kenodegard kenodegard marked this pull request as ready for review March 28, 2022 14:59
@kenodegard kenodegard requested a review from a team as a code owner March 28, 2022 14:59
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kenodegard kenodegard force-pushed the remove-unused-auxlib branch from f7b7ac5 to c76cd5b Compare March 30, 2022 00:09
@kenodegard kenodegard merged commit ab60ca0 into conda:master Mar 30, 2022
@kenodegard kenodegard deleted the remove-unused-auxlib branch March 30, 2022 16:07
travishathaway pushed a commit to travishathaway/conda that referenced this pull request Apr 5, 2022
* Remove unused auxlib.configuration

* Remove unused auxlib.crypt

* Remove unused auxlib.deprecation

* Remove unused auxlib.factory

* Remove (almost) unused auxlib.path
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused parts of auxlib
3 participants