Skip to content

Remove deprecated conda.cli.activate #11309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2022
Merged

Remove deprecated conda.cli.activate #11309

merged 4 commits into from
Mar 23, 2022

Conversation

kenodegard
Copy link
Contributor

conda.cli.activate was deprecated 4 years ago.

@kenodegard
Delete activate.py
1a4b641
@kenodegard
Refactor script vs source entrypoints
bd72c22 
Abstracting the idea of commands either being invoked "normally" as a script/executable versus being sourced as is needed for activate and friends.
@kenodegard kenodegard self-assigned this Mar 9, 2022
@kenodegard kenodegard requested a review from a team as a code owner March 9, 2022 18:15
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 9, 2022
@kenodegard kenodegard mentioned this pull request Mar 9, 2022
Open
23 tasks
@kenodegard kenodegard force-pushed the remove-conda.cli.activate branch from 96b1d77 to bf513e5 Compare March 9, 2022 19:17
@kenodegard kenodegard linked an issue Mar 11, 2022 that may be closed by this pull request
Remove deprecated conda.cli.activate #11318
Closed
@kenodegard kenodegard mentioned this pull request Mar 11, 2022
Open
conda-bot
conda-bot previously approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@conda-bot conda-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

@conda-bot conda-bot dismissed their stale review March 23, 2022 15:13

Wrong account ;)

jezdez
jezdez approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

@jezdez jezdez merged commit 554bf96 into conda:master Mar 23, 2022
@kenodegard kenodegard added this to the 4.13.0 milestone Mar 23, 2022
jezdez added a commit to jezdez/mamba that referenced this pull request Mar 23, 2022
@jezdez
Remove import of init_std_stream_encoding.
6b614e3 
This was removed in conda/conda#11309 and had already been defunct on Python 3 for a while.
@jezdez jezdez mentioned this pull request Mar 23, 2022
Merged
@kenodegard kenodegard mentioned this pull request Jul 26, 2022
Merged
3 tasks
@kenodegard kenodegard deleted the remove-conda.cli.activate branch July 28, 2022 18:12
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

@beeankha beeankha beeankha approved these changes

@conda-bot conda-bot conda-bot left review comments

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated conda.cli.activate
5 participants
@kenodegard @jezdez @conda-bot @beeankha @anaconda-issue-bot