Skip to content

Conversation

FFY00
Copy link
Contributor

@FFY00 FFY00 commented Feb 7, 2022

No description provided.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 requested a review from jezdez February 7, 2022 19:54
@FFY00 FFY00 requested a review from a team as a code owner February 7, 2022 19:54
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 7, 2022
@FFY00
Copy link
Contributor Author

FFY00 commented Feb 7, 2022

@jezdez could you ping the documentation person on anaconda's side? Thanks!

@jezdez jezdez requested a review from kathatherine February 8, 2022 10:40
@jezdez
Copy link
Member

jezdez commented Feb 8, 2022

Hey @kathatherine, would you mind taking a quick look if that sounds fine for you?

@FFY00 FFY00 changed the title plugins: add plugin mechanism barebones docs: add plugin API Feb 8, 2022
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than my one comment.

@jezdez jezdez added the plugins pertains to a plugin/subcommand label Feb 14, 2022
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit

Comment on lines 8 to 9
Plugins are implemented via pluggy_ and discovered using Python package
entrypoints. You may refeer to pluggy_'s documentation for full description of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a link to https://packaging.python.org/en/latest/specifications/entry-points/ for the Python entry points docs.

Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@jezdez jezdez merged commit 131178e into plugins Feb 23, 2022
FFY00 added a commit that referenced this pull request Feb 23, 2022
* docs: add plugin API

Signed-off-by: Filipe Laíns <lains@riseup.net>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update docs/source/plugin-api/index.rst

Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>

* Update docs/source/plugin-api/index.rst

* Update docs/source/plugin-api/index.rst

* Update docs/source/plugin-api/index.rst

* Update docs/source/plugin-api/index.rst

Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jannis Leidel <jannis@leidel.info>
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@jezdez jezdez deleted the plugins-docs branch March 10, 2022 12:07
FFY00 added a commit that referenced this pull request Mar 21, 2022
* docs: add plugin API

Signed-off-by: Filipe Laíns <lains@riseup.net>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update docs/source/plugin-api/index.rst

Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>

* Update docs/source/plugin-api/index.rst

* Update docs/source/plugin-api/index.rst

* Update docs/source/plugin-api/index.rst

* Update docs/source/plugin-api/index.rst

Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jannis Leidel <jannis@leidel.info>
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity plugins pertains to a plugin/subcommand
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants