Try using maintained ruamel.yaml #11014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conda specific fork is maintained as a conda package only in https://github.com/conda-forge/ruamel_yaml-feedstock/tree/master/recipe. My understanding of what's being patched there seems to indicate it's just the __init__.py file. I'm hoping just a rename of the import will be enough, or at least surface what real problems exist. Ref conda#10691
2 tasks
|
I couldn't get the tests to run locally on my machine yet, hopefully someone can approve this and it'll tell me what's failing! |
jezdez
reviewed
Nov 24, 2021
| from ruamel_yaml.scanner import ScannerError | ||
| from ruamel.yaml.comments import CommentedSeq, CommentedMap | ||
| from ruamel.yaml.reader import ReaderError | ||
| from ruamel.yaml.scanner import ScannerError | ||
| except ImportError: # pragma: no cover | ||
| from ruamel.yaml.comments import CommentedSeq, CommentedMap # pragma: no cover | ||
| from ruamel.yaml.reader import ReaderError |
There was a problem hiding this comment.
This try/except block can be simplified now that we're using ruamel.yaml here properly.
|
@yuvipanda Any chance you could rebase this? |
This was referenced Sep 12, 2022
|
Fixed via #11837. |
|
OMG THANK YOU @jezdez!!!!!!!!!!!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conda specific fork is maintained as a conda package only
in
https://github.com/conda-forge/ruamel_yaml-feedstock/tree/master/recipe.
My understanding of what's being patched there seems to indicate it's
just the
__init__.pyfile. I'm hoping just a rename of theimport will be enough, or at least surface what real problems exist.
Ref #10691