Fix error output bug in rename tests #11996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven6002
reviewed
Oct 19, 2022
|
|
||
| assert locate_prefix_by_name(TEST_ENV_NAME_2) | ||
| with pytest.raises(EnvironmentNameNotFound): | ||
| locate_prefix_by_name(TEST_ENV_NAME_1) | ||
| assert err == "" |
There was a problem hiding this comment.
you could add the same assert error is None
sven6002
reviewed
Oct 19, 2022
|
|
||
| # Make sure both environments still exist | ||
| assert locate_prefix_by_name(TEST_ENV_NAME_2) | ||
| assert locate_prefix_by_name(TEST_ENV_NAME_1) | ||
| assert err == "" |
There was a problem hiding this comment.
instead of removing still keep it to check for if there is an error in the environment. assert error is None
There was a problem hiding this comment.
def run_inprocess_conda_command(command, disallow_stderr: bool = True): ... return c.stdout, c.stderr, exit_code
Since we are outputting the new message to stderr, err will contain that message instead of the empty string.
Co-authored-by: travishathaway <travis.j.hathaway@gmail.com>
831b880 to
89f28c4
Compare
travishathaway
added a commit
to travishathaway/conda
that referenced
this pull request
Oct 20, 2022
* Fix error output bug in rename tests Co-authored-by: travishathaway <travis.j.hathaway@gmail.com>
travishathaway
added a commit
to travishathaway/conda
that referenced
this pull request
Oct 20, 2022
* Fix error output bug in rename tests Co-authored-by: travishathaway <travis.j.hathaway@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11905
All of the tests in
tests/cli/conda_main_rename.pyfail on feature branches due to thenotify_outdated_condawarning.