Remove vendored six.py and dependencies on it. #11979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thank you! |
|
Any idea on the failed macos test? |
|
We'll be able to take a look Monday.
…On Fri, Oct 14, 2022 at 4:26 PM erykoff ***@***.***> wrote:
Any idea on the failed macos test?
—
Reply to this email directly, view it on GitHub
<#11979 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABSZETWN73N3B2E4EAQIVDWDG6WLANCNFSM6AAAAAARFPTINI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
These exports are maintained for compatibility with conda-build and other downstream products which might depend on them.
3 tasks
travishathaway
approved these changes
Oct 18, 2022
2 tasks
jeskowagner
pushed a commit
to jeskowagner/conda
that referenced
this pull request
Nov 9, 2022
* Remove six dependency from compat.py. * Replace six.wraps with py3 functools.wraps. * Remove dependency on six and replace with py3 types. * Remove six dependency and replace with py3 types. * Replace six exports with native types. These exports are maintained for compatibility with conda-build and other downstream products which might depend on them. * Remove vendored six.py. * Fix primitive_types. * Remove six license file and remove six from vendor.txt. * Remove unused chain import. * Add news fragment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to remove the vendored six.py and update remaining compatibility dependencies on it.
The tricky thing is that some of the six functions are exported for use in (e.g.) conda-build: https://github.com/conda/conda-build/blob/main/conda_build/conda_interface.py#L71-L72 I have updated these for py3 only, but this may not be the best option; feedback welcome. It may be worthwhile to add a deprecation to exported
iteritems()?Also, I would not be shocked if the first run through CI with this PR doesn't work.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?