Skip to content

Improve CLI warning about updating conda #11796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

ForgottenProgramme
Copy link
Contributor

@ForgottenProgramme ForgottenProgramme commented Sep 5, 2022

Resolves #11300

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@ForgottenProgramme ForgottenProgramme requested a review from a team as a code owner September 5, 2022 11:40
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @ForgottenProgramme.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ForgottenProgramme there's an issue out there for this correct? can you link that issue in the PR body above?

let's also include a news snippet

@kenodegard
Copy link
Contributor

@conda-bot check

@ForgottenProgramme
Copy link
Contributor Author

@kenodegard
Done!

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 5, 2022
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review for my requested changes.

jezdez
jezdez previously approved these changes Oct 5, 2022
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ForgottenProgramme!

@LtDan33 LtDan33 added the in-progress issue is actively being worked on label Oct 18, 2022
@LtDan33 LtDan33 assigned LtDan33 and ForgottenProgramme and unassigned LtDan33 Oct 18, 2022
@beeankha beeankha self-requested a review October 18, 2022 15:53
@travishathaway travishathaway removed the in-progress issue is actively being worked on label Oct 19, 2022
@travishathaway travishathaway dismissed kenodegard’s stale review October 19, 2022 09:48

Ken is out on vacation and we have resolved his concerns.

@travishathaway travishathaway merged commit c79e033 into conda:main Oct 19, 2022
jeskowagner pushed a commit to jeskowagner/conda that referenced this pull request Nov 9, 2022
* add warning about how to reduce the number of packages updated during conda update

* remove extra line

* add news item

* Use f-string for this.

Co-authored-by: Mahe Iram Khan <maheiramkhan@Mahes-MacBook-Pro.fritz.box>
Co-authored-by: Jannis Leidel <jannis@leidel.info>
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace conda update -n base conda by conda install -n base "conda=version"?
6 participants