-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add conda._vendor.toolz
fallback for tlz
#11709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue keeps on giving!
Could we replace the |
Am curious, why not just use |
I would replace all the concat/concatv with the equivalent itertools calls (already a C module) and redirect all import fallbacks through an intermediate "the toolz we ulze" module... seems preferable to use |
@dholth @jakirkham would love to but unfortunately, since conda/conda-build haven't been built/packaged with |
Sorry @kenodegard that was a question intended for @dholth |
Description
Yet another patch to fix the broken canary builds. Adding fallback imports to
conda._vendor.toolz
for alltlz
imports.This is necessary because of how
conda build
builds packages:conda build
generates the necessary build environment (which contains the new conda dependencies, e.g.toolz
)conda build
generates abuild_env_setup.sh
script where at the very end, it runs something like:conda build
changes directories to the working directory (in this case a shallow clone of our conda repo)conda build
runs thebuild_env_setup.sh
from our working directory so whenpath/to/python -m conda ...
is invoked the CWD (working directory) is added to Python's search path, and hence the conda source code is loaded even though all we are attempting to do is bootstrap the build environment.The correct fix is to change the
path/to/python -m conda ...
command topath/to/conda ...
but this is a chicken/egg problem, so we need to keep this PR's fix in place until conda-build is updated and released.Xref: #11698
Checklist - did you ...
Add a file to thenews
directory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?