Require toolz & soften cytoolz dependency
#11700
Conversation
|
@travishathaway @kenodegard, would be interested in your feedback here 🙂 |
bcd24dd
|
Pushed a small tweak to the news entry since it sounds like we are ok with this change. Thanks all for taking a look 🙏 |
|
🤦🏼♂️ conda-build imports from |
|
Nvm Ken beat me to it 😂 Please see PR ( conda/conda-build#4556 ) |
|
Okay, I've merged the conda-build fix, this is a bit of a mess, glad we fix this now :) |
There was a problem hiding this comment.
I still think we need to leave cytoolz as a hard dependency for a few releases (at least until the end of the year?), thoughts @jezdez?
As the codebase can benefit from `cytoolz` when present and still fallback to `toolz` when `cytoolz` is absent, would suggest softening the dependency here to just require `toolz`. This can be particularly helpful when supporting other Python implementations (like PyPy, etc.) since `toolz` is pure Python and should just work out-of-the-box. Thus this simplifies the process of bootstrapping a new Python implementation with Conda. Additionally if one or the other is faster for a Python implementation, this leaves it up to users to decide.
Needed by `conda init --install`.
|
Thanks Ken and Jannis for shepherding these through 🙂 |
|
@jakirkham thanks for your help on all of these, waiting to see if the canary builds start passing again with this latest PR |
|
Please let me know what you find out |
Description
As the codebase can benefit from
cytoolzwhen present and still fallback totoolzwhencytoolzis absent, would suggest softening the dependency here to just requiretoolz. This can be particularly helpful when supporting other Python implementations (like PyPy, etc.) sincetoolzis pure Python and should just work out-of-the-box. Thus this simplifies the process of bootstrapping a new Python implementation with Conda. Additionally if one or the other is faster for a Python implementation, this leaves it up to users to decide.xref: #11698, #11589, conda/conda-build#4556
supersedes: #11699
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?