Skip to content

Use **kwargs instead of OrderedDict for _Activator.get_export_unset_vars #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 1, 2022
Merged

Use **kwargs instead of OrderedDict for _Activator.get_export_unset_vars #11649

merged 7 commits into from
Aug 1, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jul 22, 2022 •
edited
Loading

Description

Since conda has dropped Python 3.6 support, we can finally switch to using **kwargs instead of using OrderedDict.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team as a code owner July 22, 2022 20:54
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 22, 2022
@kenodegard kenodegard force-pushed the update-get_export_unset_vars branch 2 times, most recently from 99806af to c3f5324 Compare July 22, 2022 21:44
@kenodegard kenodegard force-pushed the update-get_export_unset_vars branch from c3f5324 to 544df87 Compare July 22, 2022 22:02
@kenodegard kenodegard added the in-progress issue is actively being worked on label Jul 27, 2022
@kenodegard kenodegard self-assigned this Jul 27, 2022
@kenodegard kenodegard force-pushed the update-get_export_unset_vars branch 2 times, most recently from 5935af4 to 3791f69 Compare July 27, 2022 19:12
@kenodegard kenodegard force-pushed the update-get_export_unset_vars branch from 3791f69 to 228454d Compare July 27, 2022 19:13
@kenodegard kenodegard mentioned this pull request Jul 28, 2022
Merged
3 tasks
@travishathaway travishathaway added the source::anaconda created by members of Anaconda, Inc. label Jul 28, 2022
travishathaway
travishathaway approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pull request is good as-is, but there are a couple things I commented on that I would like you to consider (namely, the line that isn't being covered by our tests at the moment). I'd also like to thank you for removing some very confusing import statements! Death to OrderDict! 🤣

@kenodegard kenodegard force-pushed the update-get_export_unset_vars branch from 60f79b8 to 6e71f73 Compare July 29, 2022 20:24
@kenodegard kenodegard force-pushed the update-get_export_unset_vars branch from b1145fd to 374e79b Compare August 1, 2022 15:41
jezdez
jezdez approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a news item, even if it's an internal refactoring, people may be relying on internal state being stored as an OrderedDict somewhere out there.

@jezdez jezdez added this to the 4.14.0 milestone Aug 1, 2022
@kenodegard kenodegard merged commit 818a2d1 into conda:main Aug 1, 2022
@kenodegard kenodegard deleted the update-get_export_unset_vars branch August 1, 2022 18:54
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

@travishathaway travishathaway travishathaway approved these changes

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
🧭 Planning
Archived in project
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kenodegard @jezdez @travishathaway @conda-bot