Skip to content

Add cytoolz as dependency #11589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 8, 2022
Merged

Add cytoolz as dependency #11589

merged 6 commits into from
Aug 8, 2022

Conversation

travishathaway
Copy link
Contributor

@travishathaway travishathaway commented Jun 28, 2022 •
edited by kenodegard
Loading

Description

This removes the toolz module from our vendored dependencies. Instead, we will rely explicitly on cytoolz from now on.

Resolves #11333

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@travishathaway travishathaway requested a review from a team as a code owner June 28, 2022 14:55
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 28, 2022
kenodegard
kenodegard requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warrants a news snippet.

kenodegard
kenodegard previously approved these changes Jun 29, 2022
View reviewed changes
@kenodegard
Copy link
Contributor

kenodegard commented Jun 29, 2022 •
edited
Loading

Just reviewed all of our other repos and found this impacts other repos. conda._vendor.toolz is used in both constructor and conda-libmamba-solver.

We'd also need to submit PRs updating both https://github.com/AnacondaRecipes/conda-feedstock and https://github.com/conda-forge/conda-feedstock.

@jezdez jezdez changed the title Add cytoolz as dependency [issue #11333] Add cytoolz as dependency Jul 18, 2022
This was referenced Jul 28, 2022
Merged
Merged
@travishathaway travishathaway added the source::anaconda created by members of Anaconda, Inc. label Jul 28, 2022
jakirkham
jakirkham reviewed Aug 3, 2022
View reviewed changes
kenodegard
kenodegard previously approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kenodegard kenodegard enabled auto-merge (squash) August 8, 2022 14:59
@kenodegard kenodegard merged commit 6147080 into conda:main Aug 8, 2022
@jakirkham jakirkham mentioned this pull request Aug 8, 2022
Merged
3 tasks
@kenodegard kenodegard mentioned this pull request Aug 16, 2022
Closed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kenodegard kenodegard kenodegard approved these changes

+1 more reviewer

@jakirkham jakirkham jakirkham left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace toolz dependency with cytoolz
4 participants
@travishathaway @kenodegard @jakirkham @conda-bot