Catch all exceptions in context.user_agent #11455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaimergp Yeah, I know it's a pretty big anti-pattern, but we should swallow exceptions to make user experience not a problem. It's not great, but better than risking stuff. |
jezdez
approved these changes
May 4, 2022
|
@jezdez - do we want to log the exception via |
Yeah, good idea. |
Co-authored-by: Jannis Leidel <jannis@leidel.info>
ee56786 to
49ce013
Compare
jezdez
approved these changes
May 9, 2022
…onda into user-agent-ignore-importerror
|
You can merge this anytime now @jezdez! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Follow-up for #11415 - ignore
ImportErrortoo if the solver cannot be imported. Otherwise,conda infowill fail (and it might be used for debugging purposes).Actually, we might want to ignore all exceptions in this block?
@jezdez