Skip to content

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Apr 27, 2022

Description

Resolves #11438

Attempts to extract the reason/message from the HTTP response body. If successful these are used instead of any hardcoded reason/message.

Error Old New
403
429

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this Apr 27, 2022
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 27, 2022
@kenodegard kenodegard force-pushed the improve-condahttperror branch from 033d9dc to 0749a5e Compare April 27, 2022 18:15
@kenodegard kenodegard force-pushed the improve-condahttperror branch from 0749a5e to 5bbfd5f Compare April 27, 2022 21:48
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around! I just had a couple suggestions based on a bug I found.

Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good

Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kenodegard
Copy link
Contributor Author

kenodegard commented Apr 28, 2022

@travishathaway oh you moved the imports all the way to the top top (I misread and thought you were gonna move it to the top of the method). So we have to be very careful doing so, all of the local imports through conda are to cut down on the runtime overhead/startup cost. So make sure to check benchmarks when making such changes. It probably doesn't make a difference here, just something to keep in mind.

@kenodegard kenodegard force-pushed the improve-condahttperror branch 2 times, most recently from ef39852 to a019453 Compare April 28, 2022 17:53
@kenodegard kenodegard force-pushed the improve-condahttperror branch from a019453 to 62d4643 Compare April 28, 2022 18:05
@kenodegard kenodegard marked this pull request as ready for review April 28, 2022 18:07
@kenodegard kenodegard requested a review from a team as a code owner April 28, 2022 18:07
@jezdez jezdez merged commit fa34108 into conda:master Apr 29, 2022
@kenodegard kenodegard deleted the improve-condahttperror branch May 2, 2022 15:05
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CondaHTTPError to include the response body
4 participants