-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Include HTTP response's reason/message if present #11440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
033d9dc
to
0749a5e
Compare
0749a5e
to
5bbfd5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turn around! I just had a couple suggestions based on a bug I found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@travishathaway oh you moved the imports all the way to the top top (I misread and thought you were gonna move it to the top of the method). So we have to be very careful doing so, all of the local imports through |
ef39852
to
a019453
Compare
a019453
to
62d4643
Compare
Description
Resolves #11438
Attempts to extract the reason/message from the HTTP response body. If successful these are used instead of any hardcoded reason/message.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?