Skip to content

Remove unused exceptions #11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2022
Merged

Remove unused exceptions #11424

merged 4 commits into from
Apr 28, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Apr 22, 2022 •
edited
Loading

Description

Removes conda.exceptions.CommandArgumentError in favor of conda.exceptions.ArgumentError.

Removes:

  • conda.exceptions.TooFewArgumentsError
  • conda.exceptions.CondaRevisionError
  • conda.exceptions.InstallError
  • conda.exceptions.CondaTypeError
  • conda.exceptions.CaseInsensitiveFileSystemError
  • conda_env.exceptions.NoBinstar
  • conda_env.exceptions.AlreadyExist
  • conda_env.exceptions.EnvironmentAlreadyInNotebook
  • conda_env.exceptions.EnvironmentFileDoesNotExist
  • conda_env.exceptions.InvalidLoader
  • conda_env.exceptions.NBFormatNotInstalled

See #11321

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team as a code owner April 22, 2022 08:54
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 22, 2022
@kenodegard kenodegard force-pushed the remove-unused-exceptions branch from 15b7d41 to 0642413 Compare April 22, 2022 09:04
This was referenced Apr 22, 2022
Merged
Open
beeankha
beeankha reviewed Apr 22, 2022
View reviewed changes
tests/test_exceptions.py
UnknownPackageClobberError,
conda_exception_handler,
ExceptionHandler,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for consistently improving the readability of the codebase via your PRs!!

beeankha
beeankha approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jezdez
jezdez approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drool Thank you!

@jezdez jezdez merged commit 91df955 into conda:master Apr 28, 2022
@kenodegard kenodegard deleted the remove-unused-exceptions branch July 28, 2022 18:12
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

@beeankha beeankha beeankha approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenodegard @jezdez @beeankha @anaconda-issue-bot