Skip to content

extend user-agent if solver != default #11415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 4, 2022
Merged

extend user-agent if solver != default #11415

merged 9 commits into from
May 4, 2022

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Apr 14, 2022 •
edited by kenodegard
Loading

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 14, 2022
jezdez
jezdez reviewed Apr 14, 2022
View reviewed changes
@jaimergp jaimergp linked an issue Apr 14, 2022 that may be closed by this pull request
Update user agent to indicate use of libmamba solver #11413
Closed
6 tasks
@jaimergp jaimergp mentioned this pull request Apr 14, 2022
Merged
jezdez
jezdez reviewed Apr 14, 2022
View reviewed changes
jezdez
jezdez requested changes Apr 29, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor update to not do attribute and callable checks without reason, we can just take the fast path with exceptions. Alternatively this could just be a class attribute and we wouldn't call a method at all.

@jezdez jezdez marked this pull request as ready for review May 3, 2022 17:10
@jezdez jezdez requested a review from a team as a code owner May 3, 2022 17:10
jezdez
jezdez approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just needs a news file TBH.

@jezdez jezdez mentioned this pull request May 4, 2022
Closed
6 tasks
@jezdez jezdez enabled auto-merge (squash) May 4, 2022 08:32
@jezdez jezdez merged commit 8e411c3 into conda:master May 4, 2022
@jaimergp jaimergp mentioned this pull request May 4, 2022
Merged
3 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update user agent to indicate use of libmamba solver
3 participants
@jaimergp @jezdez @anaconda-issue-bot