Skip to content

Conversation

dbast
Copy link
Member

@dbast dbast commented Aug 17, 2021

NOTE: This was previous opened in #10854 but got closed accidentally.

This does a number of things:

  • Use more runners for the integration tests by splitting the tests into groups
  • Fix Codecov reporting on Windows
  • Separates the documentation build into own workflow (only triggered upon changes to docs files)
  • Combine various requirements files.
  • Add pytest-rerunfailures to be able to rerun flaky tests.
  • Refactor a few unittest style tests to be pytest tests to reduce flakiness.
  • Move pytest config file and fixtures in better places.
  • Fix temp folder issue on Windows.
  • Cleanup Makefile.
  • Lint on all platforms, in an own workflow file.

Fix #10846.

@dbast dbast requested a review from a team as a code owner August 17, 2021 08:51
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 17, 2021
@jezdez jezdez removed the request for review from a team August 18, 2021 13:22
@jezdez jezdez force-pushed the test-improvements branch from 3ed12e6 to 8312b20 Compare August 18, 2021 22:22
@jezdez jezdez self-assigned this Aug 19, 2021
@jezdez jezdez changed the title WIP A few test suite improvements Test suite improvements for usability, correctness and performance Aug 19, 2021
jezdez and others added 23 commits August 19, 2021 15:18
* Convert Python version in .readthedocs.yml to string

Correct according to:
https://raw.githubusercontent.com/readthedocs/readthedocs.org/master/readthedocs/rtd_tests/fixtures/spec/v2/schema.json

* Refactor docs logic

* Move to own workflow to trigger only on docs changes
* Remove git docs detect magic from ./ci/*_tests.sh that was used
  previously to avoid test runs on docs only changes.
* Move ci/build_docs.sh logic to docs/Makefile
* Use dedicated env for doc builds to avoid base env polution on local runs
* Use docs/Makefile targets during docs.yml flow run

* Change something in ./docs/ to trigger a docs build
* Clone without history
* Don't pull the huge conda ci image
* Use a dedicated lint env
@jezdez jezdez mentioned this pull request Aug 20, 2021
@jezdez
Copy link
Member

jezdez commented Aug 20, 2021

I've moved the work on adding macOS to a separate branch since it'll need more work: #10875

@jezdez
Copy link
Member

jezdez commented Aug 20, 2021

All Linux and Windows tests pass now, with ~30 mins runtime.

@jezdez
Copy link
Member

jezdez commented Aug 20, 2021

The required checks in the protected branch settings will need to be updated for this to be easily merged.

@jezdez jezdez merged commit 27c559c into master Aug 23, 2021
@jezdez jezdez deleted the test-improvements branch August 23, 2021 19:56
FaustinCarter pushed a commit to FaustinCarter/conda that referenced this pull request Nov 27, 2021
…onda#10864)

NOTE: This was previous opened in conda#10854 but got closed accidentally.

This does a number of things:
- Use more runners for the integration tests by splitting the tests into groups
- Fix Codecov reporting on Windows
- Separates the documentation build into own workflow (only triggered upon changes to docs files)
- Combine various requirements files.
- Add pytest-rerunfailures to be able to rerun flaky tests.
- Refactor a few unittest style tests to be pytest tests to reduce flakiness.
- Move pytest config file and fixtures in better places.
- Fix temp folder issue on Windows.
- Cleanup Makefile.
- Lint on all platforms, in an own workflow file.

Fix conda#10846.

Co-authored-by: Jannis Leidel <jannis@leidel.info>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI speed by using more GitHub actions jobs
4 participants