-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Test suite improvements for usability, correctness and performance #10864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ed12e6
to
8312b20
Compare
* Convert Python version in .readthedocs.yml to string Correct according to: https://raw.githubusercontent.com/readthedocs/readthedocs.org/master/readthedocs/rtd_tests/fixtures/spec/v2/schema.json * Refactor docs logic * Move to own workflow to trigger only on docs changes * Remove git docs detect magic from ./ci/*_tests.sh that was used previously to avoid test runs on docs only changes. * Move ci/build_docs.sh logic to docs/Makefile * Use dedicated env for doc builds to avoid base env polution on local runs * Use docs/Makefile targets during docs.yml flow run * Change something in ./docs/ to trigger a docs build
* Clone without history * Don't pull the huge conda ci image * Use a dedicated lint env
Merged
I've moved the work on adding macOS to a separate branch since it'll need more work: #10875 |
All Linux and Windows tests pass now, with ~30 mins runtime. |
The required checks in the protected branch settings will need to be updated for this to be easily merged. |
chenghlee
approved these changes
Aug 23, 2021
FaustinCarter
pushed a commit
to FaustinCarter/conda
that referenced
this pull request
Nov 27, 2021
…onda#10864) NOTE: This was previous opened in conda#10854 but got closed accidentally. This does a number of things: - Use more runners for the integration tests by splitting the tests into groups - Fix Codecov reporting on Windows - Separates the documentation build into own workflow (only triggered upon changes to docs files) - Combine various requirements files. - Add pytest-rerunfailures to be able to rerun flaky tests. - Refactor a few unittest style tests to be pytest tests to reduce flakiness. - Move pytest config file and fixtures in better places. - Fix temp folder issue on Windows. - Cleanup Makefile. - Lint on all platforms, in an own workflow file. Fix conda#10846. Co-authored-by: Jannis Leidel <jannis@leidel.info>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
[bot] added once the contributor has signed the CLA
locked
[bot] locked due to inactivity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This was previous opened in #10854 but got closed accidentally.
This does a number of things:
Fix #10846.