Skip to content

We rename ruamel_yaml to ruamel_yaml_conda in our ruamel_yaml package #10441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2021
Merged

We rename ruamel_yaml to ruamel_yaml_conda in our ruamel_yaml package #10441

merged 3 commits into from
Jan 4, 2021

Conversation

mingwandroid
Copy link
Contributor

Changes:

  1. Attempting to install conda-build via python setup.py develop would result in:
  ..
  File "/opt/Shared.local/asrc/conda-build/conda_build/conda_interface.py", line 9, in <module>
    from pkg_resources import parse_version
  File "/opt/conda/lib/python3.9/site-packages/pkg_resources/__init__.py", line 3239, in <module>
    def _initialize_master_working_set():
  File "/opt/conda/lib/python3.9/site-packages/pkg_resources/__init__.py", line 3222, in _call_aside
    f(*args, **kwargs)
  File "/opt/conda/lib/python3.9/site-packages/pkg_resources/__init__.py", line 3251, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/opt/conda/lib/python3.9/site-packages/pkg_resources/__init__.py", line 567, in _build_master
    ws.require(__requires__)
  File "/opt/conda/lib/python3.9/site-packages/pkg_resources/__init__.py", line 884, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/opt/conda/lib/python3.9/site-packages/pkg_resources/__init__.py", line 770, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'ruamel_yaml>=0.11.14' distribution was not found and is required by conda

.. this is fixed.

  1. Fix Windows dev so that the dev/test-requirements.txt get installed, preferring defaults but falling back to CF.
  2. Fix incorrect assumptions about uname -o working everywhere (which didn't cause an issue beyond ugly build logs).

@mingwandroid mingwandroid requested a review from a team as a code owner January 2, 2021 07:20
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 2, 2021
cjmartian
cjmartian approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@cjmartian cjmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjmartian cjmartian merged commit c53a3a4 into conda:master Jan 4, 2021
@mingwandroid
Copy link
Contributor Author

Thanks @cjmartian. @clee please also review.

chenghlee
chenghlee reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@chenghlee chenghlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jezdez jezdez mentioned this pull request May 26, 2021
Closed
4 tasks
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenghlee chenghlee chenghlee left review comments

+1 more reviewer

@cjmartian cjmartian cjmartian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mingwandroid @chenghlee @cjmartian @anaconda-issue-bot