-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
in-progressissue is actively being worked onissue is actively being worked onlocked[bot] locked due to inactivity[bot] locked due to inactivitysource::communitycatch-all for issues filed by community memberscatch-all for issues filed by community memberstype::featurerequest for a new feature or capabilityrequest for a new feature or capabilitytype::tech-debtidentifies or resolves some technical debtidentifies or resolves some technical debt
Description
Checklist
- I added a descriptive title
- I searched for other feature requests and couldn't find a duplicate (including also the
type-feature
tag) - I confirmed that it's not related to another project (see the above section)
What is the idea?
The last upgrade the vendored tqdm
appears to have happened in PR ( #10721 ). This bumped tqdm
to version 4.61.1
. However since then several more versions of tqdm
have been released. The latest being 4.64.0
.
Why is this needed
We would like to do a better job of staying up to date with the latest tqdm
, so we are going to see what adding it as a regular dependency looks like.
What should happen?
We will create a pull request demonstrating what this looks like and then discuss it with others to see if it is the right way forward.
Additional Context
Note in PR ( tqdm/tqdm#1302 ) included in version 4.63.0
, tqdm
replaced pkg_resources
with importlib.resources
. So this would also allow dropping setuptools
as a requirement.
Tasks
- Spike to investigate whether it is possible to use a dependency instead of a vendored dependency. (timebox = 1/2 day)
- Create a pull request demonstrating how this can be done:
- Add
tqdm
to oursetup.py
and conda repcipemeta.yml
and version pin it to the latest using>=
- Find all the locations in conda where we used the vendored
tqdm
and replace it with the dependency version - delete /_vendor/tqdm
- Run all the tests (submit a pull request to do this)
- See what broke (if anything) and fix it
- Add
Metadata
Metadata
Assignees
Labels
in-progressissue is actively being worked onissue is actively being worked onlocked[bot] locked due to inactivity[bot] locked due to inactivitysource::communitycatch-all for issues filed by community memberscatch-all for issues filed by community memberstype::featurerequest for a new feature or capabilityrequest for a new feature or capabilitytype::tech-debtidentifies or resolves some technical debtidentifies or resolves some technical debt
Type
Projects
Status
🏁 Done