Skip to content

[Bug Fix] Allow Json Keys with spaces in the placeholders #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ruben-mathews
Copy link

@ruben-mathews ruben-mathews commented Jul 11, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue # #551

  • Current the spaces for json keys are not causing validation exception when creating/updating the workflow def.
  • Since we are using json path to resolve the paths, we are compiling and checking if the paths is right one.

Alternatives considered

Describe alternative implementation you have considered

  • There is an alternative to remove the whitespace check. however this may start allowing users to provide invalid paths

@ruben-mathews ruben-mathews changed the title Allow Json Keys with spaces in the placeholders [Bug Fix] Allow Json Keys with spaces in the placeholders Jul 11, 2025
@ssesha
Copy link

ssesha commented Jul 21, 2025

@v1r3n can help with this?

@ssesha
Copy link

ssesha commented Jul 28, 2025

Can help with this review? @jeffbulltech @v1r3n

@Sreevani871
Copy link

any update on this @v1r3n ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants