Metrics Improvements #529
Merged
Metrics Improvements #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manan164
approved these changes
Jun 16, 2025
| @@ -70,8 +70,8 @@ conductor.default-event-queue.type=sqs | |||
| # conductor.zookeeper-lock.namespace | |||
|
|
|||
| #disable locking during workflow execution | |||
| conductor.app.workflow-execution-lock-enabled=false | |||
| conductor.workflow-execution-lock.type=noop_lock | |||
There was a problem hiding this comment.
this change feels out of place w.r.t metrics changes.
Why do we need to change these flags ?
Same comment for server-lite/src/main/resources/application.properties
| @@ -74,6 +75,8 @@ public void setupKitchenSink() { | |||
| LOGGER.info("Loading Kitchen Sink examples"); | |||
| createKitchenSink(); | |||
| } | |||
| } catch (ConflictException ignored) { | |||
| // Already present in the system :) | |||
There was a problem hiding this comment.
is this for debugging ?
There was a problem hiding this comment.
Yes and if there is a conflict it means the workflow already exists, so its OK to ignore.
|
|
||
| @Bean | ||
| public MeterRegistry getCloudWatchMetrics( | ||
| @Value("${management.cloudwatch.metrics.export.namesapce:conductor}") |
There was a problem hiding this comment.
typo?
namesapce or namespace
|
|
||
| @Bean | ||
| public MeterRegistry getAzureMonitorMeterRegistry( | ||
| @Value("${management.cloudwatch.metrics.export.instrumentationKey:null}") |
There was a problem hiding this comment.
cloudwatch or azuremonitor ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Upgrade metrics system to use the micrometer.
Conductor now supports publishing metrics to all the popular metrics systems.
See https://docs.micrometer.io/micrometer/reference/implementations.html for more details
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered